-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to egui 0.30 #234
base: main
Are you sure you want to change the base?
Upgrade to egui 0.30 #234
Conversation
How well have you tested this? |
To be honest with you.. Not at all :) |
I tested it on my project (while bumping egui, egui-wgpu and egui-winit from 0.28.1 to 0.29.1) and haven't seen any issue so far. It even seems to be running faster but I haven't benchmarked properly. |
I have now at least tried to run puffin and things are looking ok. |
I have been using this with my own project for some time now and I have not found any issues with it. |
@emilk I have been using this version with my game engine since egui 0.29 was released. It seems to be working fine |
Shall we? |
We're using puffin_egui for dimforge/rapier#758 and rely on this PR for the next update, I didn't notice regressions 🎉 |
This update somehow breaks profiling and I use for testing this example https://github.com/aclysma/profiling/tree/master/demo-puffin and this changes to Cargo.toml puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"} but with regular puffin_egui = "0.29.0" this is toml for broken version [workspace]
# This is not part of the workspace in the profiling git repository because it causes the puffin feature to be enabled
# in examples, which we don't want.
[package]
name = "demo-puffin"
version = "0.1.0"
authors = ["Philip Degarmo <[email protected]>"]
edition = "2018"
description = "Example using puffin and the profiling crate"
license = "MIT OR Apache-2.0"
readme = "../README.md"
repository = "https://github.com/aclysma/profiling"
homepage = "https://github.com/aclysma/profiling"
keywords = ["performance", "profiling"]
categories = ["development-tools::profiling"]
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[dependencies]
profiling = { path = "../profiling", features = ["profile-with-puffin"] }
puffin = "0.19.1"
puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}
egui = "0.29.1"
# wgpu also works fine here
eframe = { version = "0.29.1", default-features = false, features = ["glow"] }
log = "0.4"
env_logger = "0.11" this is the working variant [dependencies]
profiling = { path = "../profiling", features = ["profile-with-puffin"] }
puffin = "0.19.1"
puffin_egui = "0.29.0"
egui = "0.28.1"
# wgpu also works fine here
eframe = { version = "0.28.1", default-features = false, features = ["glow"] }
if I try making
it can detect puffin, but no data is displayed I have no idea why this version is failing - it's most likely config err, but please update this crate |
@Chu-4hun I made a fork of main and tried bumping However, I noticed this line is already present in the example demo in |
Its already needs to be updated to egui 0.30.0 |
I forked puffin and updated the I don't understand why |
Upgraded to egui 0.30. This required an upgrade of the toolchain to 0.81 |
That's because puffin_egui is part of this PR and is not yet released/merged |
Checklist
Description of Changes
Upgraded to egui 0.30.
Related Issues
Fixes #233