Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to egui 0.30 #234

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tedsteen
Copy link

@tedsteen tedsteen commented Sep 30, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Upgraded to egui 0.30.

Related Issues

Fixes #233

@emilk
Copy link
Collaborator

emilk commented Sep 30, 2024

How well have you tested this?

@tedsteen
Copy link
Author

tedsteen commented Oct 1, 2024

How well have you tested this?

To be honest with you.. Not at all :)
I plan to test this out on my own project when I find the time, so until then, unless someone else do some testing, we let this PR rest here..

@Azkellas
Copy link

Azkellas commented Oct 1, 2024

I tested it on my project (while bumping egui, egui-wgpu and egui-winit from 0.28.1 to 0.29.1) and haven't seen any issue so far. It even seems to be running faster but I haven't benchmarked properly.

@tedsteen
Copy link
Author

tedsteen commented Oct 1, 2024

I have now at least tried to run puffin and things are looking ok.
Will get back to you when I have done more extensive testing on my end.

@tedsteen
Copy link
Author

tedsteen commented Oct 3, 2024

I have been using this with my own project for some time now and I have not found any issues with it.
From my end this looks good to go

@maplant
Copy link

maplant commented Oct 3, 2024

@emilk I have been using this version with my game engine since egui 0.29 was released. It seems to be working fine

@tedsteen
Copy link
Author

Shall we?

@Vrixyz Vrixyz mentioned this pull request Dec 2, 2024
2 tasks
@Vrixyz
Copy link

Vrixyz commented Dec 4, 2024

We're using puffin_egui for dimforge/rapier#758 and rely on this PR for the next update, I didn't notice regressions 🎉

@Chu-4hun
Copy link

Chu-4hun commented Dec 14, 2024

This update somehow breaks profiling and puffin integration
Only puffin_egui::puffin reexport works.

I use for testing this example https://github.com/aclysma/profiling/tree/master/demo-puffin

and this changes to Cargo.toml

puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}

demo

but with regular

puffin_egui = "0.29.0"

Expected result
изображение

this is toml for broken version

[workspace]
# This is not part of the workspace in the profiling git repository because it causes the puffin feature to be enabled
# in examples, which we don't want.

[package]
name = "demo-puffin"
version = "0.1.0"
authors = ["Philip Degarmo <[email protected]>"]
edition = "2018"
description = "Example using puffin and the profiling crate"
license = "MIT OR Apache-2.0"
readme = "../README.md"
repository = "https://github.com/aclysma/profiling"
homepage = "https://github.com/aclysma/profiling"
keywords = ["performance", "profiling"]
categories = ["development-tools::profiling"]

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
profiling = { path = "../profiling", features = ["profile-with-puffin"] }

puffin = "0.19.1"
puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}
egui = "0.29.1" 
# wgpu also works fine here
eframe = { version = "0.29.1", default-features = false, features = ["glow"] }

log = "0.4"
env_logger = "0.11"

this is the working variant

[dependencies]
profiling = { path = "../profiling", features = ["profile-with-puffin"] }

puffin = "0.19.1"
puffin_egui = "0.29.0"
egui = "0.28.1" 
# wgpu also works fine here
eframe = { version = "0.28.1", default-features = false, features = ["glow"] }

if I try making


puffin = { version =  "0.19.1", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}
puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}

demo2

it can detect puffin, but no data is displayed

I have no idea why this version is failing - it's most likely config err, but please update this crate

@JasondeWolff
Copy link

@Chu-4hun I made a fork of main and tried bumping egui to 0.30.0. This results in the exact same behavior you encountered. What did it for me was calling puffin::set_scopes_on(true); anywhere on startup.

However, I noticed this line is already present in the example demo in main(), so I've no clue what's causing it to fail on your end.

@Chu-4hun
Copy link

Its already needs to be updated to egui 0.30.0

@kaphula
Copy link

kaphula commented Dec 17, 2024

I forked puffin and updated the egui, egui_extras and eframe to 0.29.0. Everything works fine it seems on my own project.

I don't understand why puffin_egui's own version is set to 0.29.0 when the egui version it uses is 0.28.0.

@tedsteen
Copy link
Author

Upgraded to egui 0.30. This required an upgrade of the toolchain to 0.81

@tedsteen
Copy link
Author

I forked puffin and updated the egui, egui_extras and eframe to 0.29.0. Everything works fine it seems on my own project.

I don't understand why puffin_egui's own version is set to 0.29.0 when the egui version it uses is 0.28.0.

That's because puffin_egui is part of this PR and is not yet released/merged

@tedsteen tedsteen changed the title Upgrade to egui 0.29 Upgrade to egui 0.30 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update puffin_egui to support egui 0.29
8 participants