Update goblin to 0.9 #711
Merged
Update goblin to 0.9 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require the new te feature so that the peek_bytes API function is still available; see the conditional in https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/src/lib.rs#L240
Jake-Shadle
pushed a commit
to Tastaturtaste/cargo-deny
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update goblin to 0.9.
The breaking change from 0.8.0 appears to be the addition of a value to a pub enum associated with TE (terse executable) support; at first glance, it does not look like this should affect cargo-deny’s usage of goblin since it doesn’t match exhaustively on this enum, but it turns out that we do need to add the new
tefeature to the requestedgoblinfeatures in order for thepeek_bytesAPI function to be available; see https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/src/lib.rs#L240 and:cargo-deny/src/bans.rs
Line 1461 in 69f1f59
With that small change, everything compiles and
cargo testpasses.https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/CHANGELOG.md#092----2024-10-26