A bug fix to the calculation of the adler32 hash when compressing dat…

…a. Also added strong name signing as well. Signed-off-by: AraHaan <[email protected]>
Elskom · Dec 26, 2023 · b409a4d · b409a4d
1 parent e904a3d
commit b409a4d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -5,6 +5,8 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <DebugType>embedded</DebugType>
+    <SignAssembly>True</SignAssembly>
+    <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)Elskom.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
 </Project>
diff --git a/Elskom.snk b/Elskom.snk
diff --git a/src/ZlibSharp/Directory.Build.props b/src/ZlibSharp/Directory.Build.props
@@ -3,11 +3,11 @@
   <Import Project="../../Directory.Build.props" />
 
   <PropertyGroup>
-    <Version>1.2.13.2</Version>
+    <Version>1.2.13.3</Version>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageReleaseNotes>
-      A minor bug fix the the previous patch release that fixes the incorect default window bits values in the various MemoryZlib members that were changed/introduced in that update.
+      A bug fix to the calculation of the adler32 hash when compressing data. Also added strong name signing as well.
     </PackageReleaseNotes>
     <Description>
       A high performance .NET zlib wrapper that is span based and offers more functionality over System.IO.Compression by allowing more developer control over how the data is compressed and by avoiding .NET's streams entirely.

diff --git a/src/ZlibSharp/ZlibSharp/Internal/ZlibHelper.cs b/src/ZlibSharp/ZlibSharp/Internal/ZlibHelper.cs
@@ -42,7 +42,7 @@ internal static uint Compress(ReadOnlySpan<byte> source, Span<byte> dest, ZlibCo
                 }
             }
 
-            adler32 = unchecked((uint)(MemoryZlib.ZlibGetAdler32(dest) & 0xFFFFFFFF));
+            adler32 = unchecked((uint)(MemoryZlib.ZlibGetAdler32(source) & 0xFFFFFFFF));
             DeflateEnd(streamPtr);
             return (uint)stream.total_out.Value;
         }

diff --git a/tests/Test.cs b/tests/Test.cs
@@ -83,7 +83,7 @@ public void DecompressionToOverAllocatedBufferShouldHaveBytesWrittenEqualToSourc
 
     [Fact]
     public void ZlibSharpVersionWorks()
-        => _ = MemoryZlib.ZlibSharpVersion().Should().Be("1.2.13.2");
+        => _ = MemoryZlib.ZlibSharpVersion().Should().Be("1.2.13.3");
 
     [Fact]
     public void ZlibVersionWorks()