Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ThrowIfDisposed() #40

Merged
merged 3 commits into from
May 7, 2024
Merged

Implement ThrowIfDisposed() #40

merged 3 commits into from
May 7, 2024

Conversation

Rekkonnect
Copy link
Collaborator

Checklist

  • I have read the Code of Conduct and the Contributing files before opening this issue.
  • I have verified the issue this pull request fixes or feature this pull request implements is to the current release.
  • I am using the latest stable release with the above code fix or the current main branch if code changes are present (prerelease code changes).
  • I have debugged and tested my changes before submitting this issue and that everything should just work.

Describe the issue this fixes / feature this adds

Closes #34

@Rekkonnect Rekkonnect requested a review from AraHaan February 27, 2024 01:08
@Rekkonnect Rekkonnect changed the title Implement ThrowIfDisposed() Implement ThrowIfDisposed() Feb 27, 2024
@mergify mergify bot added the enhancement New feature or request label Feb 27, 2024
Copy link

mergify bot commented Feb 27, 2024

This PR does not add the DCO signoff. Ensure it does before they can be scheduled for automatic merge.
To do that click the details link on the check below to find the steps to resolve this and then force push using git push --force after it has been completed.
If the PR has multiple commits to simplify it you can also run git rebase -i HEAD~x where x is the number of commits inside of the PR, then in the interactive program that is opened to edit the data change every line under the first one that starts with pick to fixup then save and exit the program git opens, after that git will rebase them into each other and squashes them into a single commit where then you can run git commit --amend --signoff then force push.

Copy link

mergify bot commented Feb 27, 2024

This PR's security check has failed. Ensure it passes before they can be scheduled for automatic merge.

Signed-off-by: Rekkonnect <[email protected]>
@AraHaan AraHaan merged commit 64bd04a into main May 7, 2024
10 checks passed
@AraHaan AraHaan deleted the throw-if-disposed branch May 7, 2024 04:56
@AraHaan AraHaan mentioned this pull request May 7, 2024
@AraHaan
Copy link
Contributor

AraHaan commented May 7, 2024

I am sorry for the delayed merge time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate internal ThrowIfDisposed() member methods.
2 participants