Replace calls to .Any() with .Count is not 0. #37

AraHaan · 2024-02-23T17:09:34Z

Checklist

I have read the Code of Conduct and the Contributing files before opening this issue.
I have verified the issue this pull request fixes or feature this pull request implements is to the current release.
I am using the latest stable release with the above code fix or the current main branch if code changes are present (prerelease code changes).
I have debugged and tested my changes before submitting this issue and that everything should just work.

Describe the issue this fixes / feature this adds

Fixes #36.

Signed-off-by: AraHaan <[email protected]>

github-advanced-security · 2024-02-23T17:41:44Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2024-02-23T17:41:44Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2024-02-23T17:41:44Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2024-02-23T17:41:44Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

src/IDisposableGenerator/DisposableCodeWriter.cs

src/IDisposableGenerator/WorkItemCollection.cs

Rekkonnect

Minor nits

src/IDisposableGenerator/DisposableCodeWriter.cs

Rekkonnect · 2024-02-23T18:19:57Z

src/IDisposableGenerator/WorkItem.cs

@@ -15,8 +15,8 @@ public override string ToString()
        var sb = new StringBuilder($"Namespace: Name: {this.Namespace}");
        foreach (var classItems in this.Classes)
        {
-            sb.AppendLine();
-            sb.Append($"Class Item {this.Classes.IndexOf(classItems)}: {classItems}");
+            _ = sb.AppendLine();


Not too sure if applying this pattern is healthy

Rekkonnect · 2024-02-23T18:20:29Z

src/IDisposableGenerator/WorkItemCollection.cs

@@ -28,7 +25,7 @@ public void Process(INamedTypeSymbol testClass, CancellationToken ct)
        var classItemsQuery =
            from att in testClass.GetAttributes()
            where att.AttributeClass!.Name.Equals(
-                "GenerateDisposeAttribute")
+                "GenerateDisposeAttribute", StringComparison.Ordinal)


Can we use nameof(GenerateDisposeAttribute) here?

I would like that very much however the attribute code files does not get directly compiled to be a part of the generator assembly, instead it gets provided as basically an output from the generator itself. I guess a workaround is to reference the generator and having it run here and then use nameof(GenerateDisposeAttribute) though.

If it's included in the generated output files, it's fine. I don't find a reason to change how the API for the generator is accessible to the user.

Signed-off-by: AraHaan <[email protected]>

mergify · 2024-02-25T11:47:32Z

This pull request is about to be automerged.

mergify

Automatically approving since automerge label was found.

AraHaan added the enhancement New feature or request label Feb 23, 2024

AraHaan added this to the v1.2.0 milestone Feb 23, 2024

AraHaan mentioned this pull request Feb 23, 2024

v1.2.0 Roadmap #30

Open

AraHaan force-pushed the replace-any-with-count branch from de5eb2b to c1e9407 Compare February 23, 2024 17:18

Replace calls to .Any() with .Count is not 0.

23d615b

Signed-off-by: AraHaan <[email protected]>

Elskom deleted a comment from mergify bot Feb 23, 2024

AraHaan marked this pull request as draft February 23, 2024 17:37

AraHaan force-pushed the replace-any-with-count branch from c1e9407 to 23d615b Compare February 23, 2024 17:37

github-advanced-security bot found potential problems Feb 23, 2024

View reviewed changes

Rekkonnect approved these changes Feb 23, 2024

View reviewed changes

Optimize a few things further.

6c156db

Signed-off-by: AraHaan <[email protected]>

AraHaan force-pushed the replace-any-with-count branch from 8a7a557 to 6c156db Compare February 23, 2024 19:36

AraHaan marked this pull request as ready for review February 25, 2024 11:46

mergify bot added the automerge Tells mergify that this pull request is ready for auto merge. label Feb 25, 2024

mergify bot approved these changes Feb 25, 2024

View reviewed changes

mergify bot merged commit 472e00a into main Feb 25, 2024
12 checks passed

mergify bot deleted the replace-any-with-count branch February 25, 2024 11:47

mergify bot removed the automerge Tells mergify that this pull request is ready for auto merge. label Feb 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace calls to .Any() with .Count is not 0. #37

Replace calls to .Any() with .Count is not 0. #37

AraHaan commented Feb 23, 2024 •

edited

Loading

github-advanced-security bot commented Feb 23, 2024

github-advanced-security bot commented Feb 23, 2024

github-advanced-security bot commented Feb 23, 2024

github-advanced-security bot commented Feb 23, 2024

Rekkonnect left a comment

Rekkonnect Feb 23, 2024

Rekkonnect Feb 23, 2024

AraHaan Feb 23, 2024

Rekkonnect Feb 23, 2024 •

edited

Loading

mergify bot commented Feb 25, 2024

mergify bot left a comment

Replace calls to .Any() with .Count is not 0. #37

Replace calls to .Any() with .Count is not 0. #37

Conversation

AraHaan commented Feb 23, 2024 • edited Loading

Checklist

Describe the issue this fixes / feature this adds

github-advanced-security bot commented Feb 23, 2024

github-advanced-security bot commented Feb 23, 2024

github-advanced-security bot commented Feb 23, 2024

github-advanced-security bot commented Feb 23, 2024

Rekkonnect left a comment

Choose a reason for hiding this comment

Rekkonnect Feb 23, 2024

Choose a reason for hiding this comment

Rekkonnect Feb 23, 2024

Choose a reason for hiding this comment

AraHaan Feb 23, 2024

Choose a reason for hiding this comment

Rekkonnect Feb 23, 2024 • edited Loading

Choose a reason for hiding this comment

mergify bot commented Feb 25, 2024

mergify bot left a comment

Choose a reason for hiding this comment

AraHaan commented Feb 23, 2024 •

edited

Loading

Rekkonnect Feb 23, 2024 •

edited

Loading