Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][BR000275][MIG] Migrate website_baidu_map from 8.0 to 12.0 #239

Open
wants to merge 13 commits into
base: 12.0
Choose a base branch
from
Open

[12.0][BR000275][MIG] Migrate website_baidu_map from 8.0 to 12.0 #239

wants to merge 13 commits into from

Conversation

ruter-lyu
Copy link

@Elico-Corp/odoo-reviewers

JoJoJoJoJoJoJo
JoJoJoJoJoJoJo approved these changes Apr 3, 2019
View reviewed changes
Copy link

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM

elicoidal
elicoidal requested changes Apr 3, 2019
View reviewed changes
website_baidu_map/README.rst Outdated Show resolved Hide resolved
website_baidu_map/views/snippets.xml Outdated Show resolved Hide resolved
website_baidu_map/views/templates.xml Outdated Show resolved Hide resolved
website_baidu_map/README.rst Show resolved Hide resolved
website_baidu_map/README.rst Outdated Show resolved Hide resolved
website_baidu_map/README.rst Outdated Show resolved Hide resolved
@ruter-lyu
Copy link
Author

@Elico-Corp/odoo-reviewers

Travis looks weird, I can not find the key support in any __manifest__.py files

website_baidu_map/__manifest__.py:3: [C8102(manifest-required-key), ] Missing required key "support" in manifest file

@elicoidal
Copy link
Contributor

You need to add one key support in the manifest with value [email protected]

@ruter-lyu ruter-lyu changed the title [12.0][MIG] Migrate website_baidu_map from 8.0 to 12.0 [12.0][BR000275][MIG] Migrate website_baidu_map from 8.0 to 12.0 Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal requested changes

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo JoJoJoJoJoJoJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruter-lyu @elicoidal @JoJoJoJoJoJoJo @noahzaozao @Rona111