-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BR1230][T25029][ADD]project_timesheet_detail #212
base: 10.0
Are you sure you want to change the base?
Conversation
Project TimeSheet Detail | ||
======================== | ||
|
||
This module extends the function of project timesheet,allows the manager to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space after the ','
======================== | ||
|
||
This module extends the function of project timesheet,allows the manager to | ||
review, approve or reject the timesheet by every single record. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by every single record -> one by one
|
||
This module extends the function of project timesheet,allows the manager to | ||
review, approve or reject the timesheet by every single record. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the runbot
=========== | ||
|
||
Bugs are tracked on `GitHub Issues | ||
<https://github.com/Elico-Corp/elico_odoo/issues>`_. In case of trouble, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the url
{ | ||
'name': "project_timesheet_detailed", | ||
'summary': """This module extends the function of project timesheet, | ||
allows the manager to review, approve or reject the timesheet by every |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update
rec.stage = 'approved' | ||
else: | ||
raise UserError( | ||
'Sorry,you do not have permission to approve it') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 'Sorry,' (everywhere)
@api.constrains('task_id', 'issue_id') | ||
def _check_task_and_issue(self): | ||
if self.task_id and self.issue_id: | ||
raise ValueError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would that happen?
string="Check TMS", | ||
default=True, | ||
help='If true, the TMS will be assigned to the manager of the' | ||
' employee,if false, the TMS will be assigned to the manager ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always ',' then a space
@@ -0,0 +1,127 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the xml format for readibility
@@ -0,0 +1,59 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<odoo> | |||
<record id="view_project_check_tms" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve XML format for readibility
replace #207