-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD][BR1187][T24354]timesheet_activity_report_improve #211
base: 10.0
Are you sure you want to change the base?
[ADD][BR1187][T24354]timesheet_activity_report_improve #211
Conversation
@@ -33,9 +33,9 @@ class TimesheetReport(models.Model): | |||
product_id = fields.Many2one('product.product', 'Product', readonly=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this file should be here?
:alt: License: AGPL-3 | ||
|
||
================================= | ||
Timesheet Activity Report Improve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timesheet completion report
module name timesheet_activity_completion_report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elicoidal
Actually the BR never mentioned to create a separate module. The improvement must be done in the existing module (simply increment version number...).
@lonelysun
Please arrange refactoring
Credits | ||
======= | ||
|
||
Images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this section (only for OCA modules)
@@ -0,0 +1,5 @@ | |||
# -*- coding: utf-8 -*- | |||
# Copyright 2015-2017 Elico corp (https://www.elico-corp.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need copyright in init.py files
{ | ||
'name': 'Timesheet Activities Report', | ||
'version': '10.0.1.1.0', | ||
'category': 'Human Resources', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add Project Management
@@ -0,0 +1,41 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File name
_inherit = 'timesheet.activity.report' | ||
|
||
br_master_project = fields.Many2one( | ||
'project.project', string='BR Master Pro.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pro. -> Project
) | ||
department_id = fields.Many2one('hr.department', string='Department') | ||
|
||
def _select(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seb-elico please review this part
<xpath expr='//div[@name="buttons"]/button[1]' position='before'> | ||
<button class="oe_inline oe_stat_button" | ||
type="object" name="br_open_tms_activity_report" | ||
icon="fa-tasks" string="TMS Com. Rep"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TMS Completion Report
<xpath expr='//button[@name="toggle_active"]' position='before'> | ||
<button class="oe_inline oe_stat_button" | ||
type="object" name="project_open_tms_activity_rep" | ||
icon="fa-tasks" string="TMS Com. Rep" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
:alt: License: AGPL-3 | ||
|
||
================================= | ||
Timesheet Activity Report Improve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elicoidal
Actually the BR never mentioned to create a separate module. The improvement must be done in the existing module (simply increment version number...).
@lonelysun
Please arrange refactoring
replace #204