Sleep time between retries #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CLI tool and its requirements, build & test instructions, dev environment setup, and exposed metrics feat(flags.go): add flags for sleepBetweenRetries, sleepBetweenRetriesBackoff, and sleepMax to allow configuring sleep intervals and backoff for retries refactor(liquidator.go): refactor variable declarations for better readability and add new variables for sleep intervals and backoff
…Swap and performReverseSwap functions to introduce delay between retries for better error handling and backoff strategy
…t it to sleepMax value for better performance and consistency
gcaracuel
previously approved these changes
Mar 27, 2024
…s to use milliseconds instead of seconds for more precise backoff timing
…limitFees, sleepBetweenRetries, sleepBetweenRetriesBackoff, and sleepMax to provide more insight into the application's behavior
…for better backoff strategy feat(.env): add SLEEPMAX variable with a value of 500ms for improved sleep duration in tests fix(liquidator_test.go): increase sleep duration in Test_monitorChannel from 1 second to 30 seconds for more reliable test execution
Jossec101
requested changes
Apr 17, 2024
| @@ -507,7 +510,7 @@ func manageChannelLiquidity(info ManageChannelLiquidityInfo) error { | |||
|
|
|||
| } | |||
|
|
|||
| func performSwap(info ManageChannelLiquidityInfo, channel *lnrpc.Channel, swapAmount int64, rule nodeguard.LiquidityRule, span trace.Span, loopdCtx context.Context, retryCounter int, swapAmountTarget int64) error { | |||
| func performSwap(info ManageChannelLiquidityInfo, channel *lnrpc.Channel, swapAmount int64, rule nodeguard.LiquidityRule, span trace.Span, loopdCtx context.Context, retryCounter int, swapAmountTarget int64, sleepBetweenRetries time.Duration) error { | |||
There was a problem hiding this comment.
if sleepBetweenRetries is a global, why send it over as a function param?
| @@ -64,53 +72,71 @@ All the flags can be set as environment variables, with the following format, ex | |||
| - RETRIESBEFOREBACKOFF (optional) : Number of retries before applying backoff to the swap (default: 3) | |||
| - BACKOFFCOEFFICIENT (optional) : Coefficient to apply to the backoff (default: 0.95) | |||
| - BACKOFFLIMIT (optional) : Limit coefficient of the backoff (default: 0.1) | |||
| - SLEEPBETWEENRETRIES (optional) : Base time to sleep between retries (default: 500ms) | |||
| - SLEEPBETWEENRETRIESBACKOFF (optional) : Coefficient to apply to the backoff (default: 1.5) | |||
| - SLEEPMAX (optional) : Maximum time to sleep between retries (default: 60s) | |||
There was a problem hiding this comment.
I think this is not useful, I would reduce code and actually control this via config rather making code more complex.
|
I guess this PR has fall behind some others and have not much sense now |
Yes, I guess so |
|
Let's close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one implemets: