Fix numeric field in the channel request and withdrawal pages. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AleksKSoftware
commented
Sep 17, 2023
•
AleksKSoftware
commented
- Fixed limitation of the withdrawal
- Fixed input and output withdrawl
AleksKSoftware
force-pushed
the
fix_edit_field
branch
from
127e38e to
2fde12d
Compare
markettes
requested changes
Sep 21, 2023
markettes
previously requested changes
Sep 21, 2023
AleksKSoftware
force-pushed
the
fix_edit_field
branch
from
2fde12d to
504e2fd
Compare
AleksKSoftware
force-pushed
the
fix_edit_field
branch
2 times, most recently
from
fdac9e4 to
fe765c1
Compare
AleksKSoftware
force-pushed
the
fix_edit_field
branch
from
fe765c1 to
20cb829
Compare
AleksKSoftware
requested review from
Jossec101 and
markettes
and removed request for
Jossec101 and
markettes
markettes
reviewed
Sep 27, 2023
|
@markettes I've update the branch again looks like you was reviewing the previous commit. |
|
I think you didn't push the commits because they are newer than my review xD |
Jossec101
reviewed
Sep 28, 2023
Jossec101
reviewed
Sep 28, 2023
RodriFS
reviewed
Oct 5, 2023
RodriFS
reviewed
Oct 5, 2023
RodriFS
approved these changes
Oct 16, 2023
markettes
reviewed
Oct 16, 2023
| : _maxChannelCapacity; | ||
| decimal convertedAmount = Math.Round(PriceConversionService.SatToUsdConversion(new Money(amountToShow, MoneyUnit.BTC).Satoshi, _btcPrice), 2); | ||
| } | ||
| @($"Amount in Satoshis. Minimum {_minimumChannelCapacity:f8}. Current amount: {convertedAmount} USD") |
There was a problem hiding this comment.
This field is in BTC. Should we fix it later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.