better image config

ElegantEngineeringTech · Aug 23, 2024 · 29dc474 · 29dc474
1 parent d4255ea
commit 29dc474
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -28,7 +28,7 @@ composer require elegantly/laravel-seo
 You can publish the config file with:
 
 ```bash
-php artisan vendor:publish --tag="laravel-seo-config"
+php artisan vendor:publish --tag="seo-config"
 ```
 
 This is the content of the published config file:

diff --git a/src/SeoData.php b/src/SeoData.php
@@ -31,9 +31,9 @@ public function __construct(
         public ?array $schemas = null,
         public ?SeoTags $customTags = null,
     ) {
-        $this->title = $title ?? config('seo.title') ?? '';
+        $this->title = $title ?? __(config('seo.title')) ?? '';
         $this->canonical = $canonical ?? URL::current();
-        $this->description = $description ?? config('seo.description');
+        $this->description = $description ?? __(config('seo.description'));
         $this->robots = $robots ?? config('seo.robots');
         $this->sitemap = $sitemap ?? config('seo.sitemap');
         $this->image = $image ?? $this->getImageFromConfig();
@@ -43,7 +43,9 @@ public function __construct(
     public function getImageFromConfig(): ?Image
     {
         if ($image = config('seo.image')) {
-            return new Image($image);
+            return new Image(
+                url: filter_var($image, FILTER_VALIDATE_URL) ? $image : asset($image)
+            );
         }
 
         return null;