Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Kancolle Server Handling #515

Merged
merged 4 commits into from
Dec 5, 2024
Merged

New Kancolle Server Handling #515

merged 4 commits into from
Dec 5, 2024

Conversation

Jebzou
Copy link
Member

@Jebzou Jebzou commented Dec 4, 2024

No description provided.

@Jebzou
Copy link
Member Author

Jebzou commented Dec 4, 2024

Todo :

  • might be better to use Task.Run to avoid any performance hits
  • keep the check if current server is null to avoid setting the server multiple times

@Jebzou Jebzou marked this pull request as ready for review December 5, 2024 17:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@myangelkamikaze myangelkamikaze merged commit 78d359a into main Dec 5, 2024
3 checks passed
@myangelkamikaze myangelkamikaze deleted the NewKancolleServerHandling branch December 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myangelkamikaze myangelkamikaze myangelkamikaze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jebzou @myangelkamikaze