NTR Heartbeat #37
Merged
NTR Heartbeat #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently broken :) NTR actually works, but NTR-HR is more borked for some NTR-HR reason.
heartbeat: - Added error-handling for non-matching seq and cmd values. Also added a simple seq implementation. - Made custom text formatting a little smarter (aesthetic change) recvPacket: - Restructured and reorganized things. - Moved most of the code for logging raw packet data to the end, so the main section of the method is a bit less cluttered. - Added somewhat more robust error-handling. Packet: - Constructor that converts from raw data now throws exceptions in some cases of bad data. misc: - Added a 10-second timeout to the Socket, just in case. Made a few minor changes to implement it. - Minor rewording of some log text to be more consistent in style.
- Now actually close the NTR UDP thread if communications seem to have failed. (I should have done this earlier.) - Generally safer behavior for socket init and closing, to properly handle edge-cases. - Specifically, there was an issue that would arise if "java.net.ConnectException: Connection refused: connect" was thrown during socket init, that is now fixed.
Can't be bothered making this less dumb at the moment.
and a couple other minor improvements.
|
If this merge causes any issues that I missed, I'll do my best to take care of them. etc, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChainSwordCS's work is about ready to merge, time to review