feat: add active param, remove un-needed look at param

EditVR · Aug 9, 2018 · 1d9483b · 1d9483b
1 parent d52a8db
commit 1d9483b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/dist/aframe-simple-link-component.js b/dist/aframe-simple-link-component.js
@@ -84,7 +84,7 @@ if (typeof AFRAME === 'undefined') {
 
 AFRAME.registerComponent('simple-link', {
   schema: {
-    lookAtCamera: {
+    active: {
       default: true,
       type: 'boolean'
     },
@@ -217,7 +217,9 @@ AFRAME.registerComponent('simple-link', {
    *
    */
   navigate: function navigate() {
-    window.location = this.data.href;
+    if (this.data.active) {
+      window.location = this.data.href;
+    }
   }
 });
 

diff --git a/dist/aframe-simple-link-component.min.js b/dist/aframe-simple-link-component.min.js
diff --git a/index.js b/index.js
@@ -11,11 +11,11 @@ if (typeof AFRAME === 'undefined') {
  */
 AFRAME.registerComponent('simple-link', {
   schema: {
-    lookAtCamera: { default: true, type: 'boolean' },
+    active: { default: true, type: 'boolean' },
     href: { default: '', type: 'string' },
     title: { default: '', type: 'string' },
     radius: { default: 1, type: 'number' },
-    font: {default: 'kelsonsans', type: 'string' },
+    font: { default: 'kelsonsans', type: 'string' },
     color: { default: '#fff', type: 'color' },
     titleColor: { default: '#fff', type: 'color' },
     image: { default: '', type: 'asset' },
@@ -106,7 +106,9 @@ AFRAME.registerComponent('simple-link', {
   },
 
   removeEventListener() {
-    const { data: { on } } = this;
+    const {
+      data: { on }
+    } = this;
     if (on) {
       this.el.removeEventListener(on, this.navigate);
     }
@@ -117,6 +119,8 @@ AFRAME.registerComponent('simple-link', {
    *
    */
   navigate() {
-    window.location = this.data.href;
+    if (this.data.active) {
+      window.location = this.data.href;
+    }
   }
 });