draft: convert DeviceShifuBase data structure #594
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the DeviceShifuBase data structure from single EdgeDevice to a list type of EdgeDevice, in the EdgeDevice struct I have changed the Spec to list type.
Line :
shifu/pkg/k8s/api/v1alpha1/edgedevice_types.go
Line 177 in bf6f284
After making this change I am unable to locate the file where I have to make changes in order to make the EdgeDeviceSpec work as a list.
In examples/httpDeviceShifu/deployment/http-edgedevice.yaml I have added a device in the array format.
This PR points to the issue #538
How is this PR tested