ECWID-122978 Add translated alt text support #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/kotlin/com/ecwid/apiclient/v3/dto/product/result/FetchedProduct.kt
Fixed
Show fixed
Hide fixed
…rt_on_product_page
…rt_on_product_page
istvan-szabo-lightspeed
requested review from
zenon-ecwid and
ZimuZhengLightspeed
zenon-ecwid
approved these changes
Nov 8, 2023
ZimuZhengLightspeed
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In order to be able to add multi-language alt text support for the static product pages in
degeneratorservice, we need to make sure that we also return the existing translations from the V3 public endpoints.Note: the old
altproperty remains there untouched, but deprecated for the time being to preserve backwards compatibility.