Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations automatiques de base de données #1046

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Conversation

thom4parisot
Copy link
Member

@thom4parisot thom4parisot commented Oct 14, 2024

  • joue les tests dans une vraie base de données en intégration continue (en ajoutant un suffixe -tests à sa suite)
  • lance les migrations dans une vraie base de données lors des tests
  • corrige deux-trois trucs de configuration dans graphql/app.js
  • se base essentiellement sur une seule valeur de configuration (DATABASE_URL) au lieu de trois (MONGO_SERVER_DB, MONGO_SERVER_PORT, MONGO_SERVER)
  • split les runners Node en plusieurs pour réduire les temps de build/CI

fixes #122

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for stylo-docs canceled.

Name Link
🔨 Latest commit 94197c5
🔍 Latest deploy log https://app.netlify.com/sites/stylo-docs/deploys/673b675d50e3cc0008f8447b

@ggrossetie
Copy link
Collaborator

Intéressant 👍🏻

working-directory: ${{ inputs.app-dir }}
run: npm test
env:
DATABASE_URL: mongodb://127.0.0.1:${{ job.services.mongodb.ports[27017] }}/stylo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je n'ai jamais vu cette syntaxe job.services.mongodb.ports[27017], entre crochets c'est la valeur par défaut ? Si c'est une reference ce n'est pas plutôt le premier élément de ports ?

Copy link
Member Author

@thom4parisot thom4parisot Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for stylo-dev ready!

Name Link
🔨 Latest commit 94197c5
🔍 Latest deploy log https://app.netlify.com/sites/stylo-dev/deploys/673b675dbee3ee0008ab2eb6
😎 Deploy Preview https://deploy-preview-1046--stylo-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thom4parisot thom4parisot force-pushed the feat/migrate-db branch 2 times, most recently from 9d5973b to a29052d Compare November 18, 2024 10:30
@ggrossetie ggrossetie changed the title Migrations automatique de base de données feat: migrations automatique de base de données Nov 18, 2024
@ggrossetie ggrossetie merged commit 95ff971 into master Nov 18, 2024
16 checks passed
@thom4parisot thom4parisot changed the title feat: migrations automatique de base de données Migrations automatiques de base de données Nov 18, 2024
@ggrossetie ggrossetie deleted the feat/migrate-db branch November 18, 2024 20:56
ggrossetie added a commit to ggrossetie/stylo that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utiliser une URL de connexion pour MongoDB dans le backend
2 participants