Skip to content

Commit

Permalink
feat(php-package): fix container name in PHP package to use new naming
Browse files Browse the repository at this point in the history
scheme
  • Loading branch information
IvanChepurnyi committed Jan 6, 2025
1 parent 30d5220 commit 4c69566
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion testcontainers-magento-data-php/src/ContainerMetadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

final class ContainerMetadata
{
private const CONTAINER_NAME = 'ghcr.io/ecomdev/testcontainer-magento-%s';
private const CONTAINER_NAME = 'ghcr.io/ecomdev/testcontainer-magento-data/%s';

public static function getImageName(string $type)
{
Expand Down
4 changes: 2 additions & 2 deletions testcontainers-magento-data-php/tests/DbContainerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function loadsMagentoSampleDataContainer()
public function generatesImageForSpecificMagentoVersion()
{
$this->assertEquals(
'ghcr.io/ecomdev/testcontainer-magento-mysql:2.4.7-p2-sampledata',
'ghcr.io/ecomdev/testcontainer-magento-data/mysql:2.4.7-p2-sampledata',
DbContainerBuilder::mysql()
->withSampleData()
->withMagentoVersion('2.4.7-p2')
Expand All @@ -116,7 +116,7 @@ public function generatesImageForSpecificMagentoVersion()
public function generatesMariadbImageForMagentoVersion()
{
$this->assertEquals(
'ghcr.io/ecomdev/testcontainer-magento-mariadb:2.4.7-p2-sampledata',
'ghcr.io/ecomdev/testcontainer-magento-data/mariadb:2.4.7-p2-sampledata',
DbContainerBuilder::mariadb()
->withSampleData()
->withMagentoVersion('2.4.7-p2')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class OpenSearchContainerTest extends TestCase
public function generatesDefaultImageNameWithLatestMagentoVersion()
{
$this->assertEquals(
'ghcr.io/ecomdev/testcontainer-magento-opensearch:latest',
'ghcr.io/ecomdev/testcontainer-magento-data/opensearch:latest',
OpenSearchContainerBuilder::new()
->getImageName()
);
Expand All @@ -24,7 +24,7 @@ public function generatesDefaultImageNameWithLatestMagentoVersion()
public function generatesDefaultImageNameWithCustomMagentoVersion()
{
$this->assertEquals(
'ghcr.io/ecomdev/testcontainer-magento-opensearch:2.4.7-p2',
'ghcr.io/ecomdev/testcontainer-magento-data/opensearch:2.4.7-p2',
OpenSearchContainerBuilder::new()
->withMagentoVersion('2.4.7-p2')
->getImageName()
Expand All @@ -36,7 +36,7 @@ public function generatesDefaultImageNameWithCustomMagentoVersion()
public function generatesSampleDataImageNameWithCustomMagentoVersion()
{
$this->assertEquals(
'ghcr.io/ecomdev/testcontainer-magento-opensearch:2.4.7-p2-sampledata',
'ghcr.io/ecomdev/testcontainer-magento-data/opensearch:2.4.7-p2-sampledata',
OpenSearchContainerBuilder::new()
->withMagentoVersion('2.4.7-p2')
->withSampleData()
Expand Down

0 comments on commit 4c69566

Please sign in to comment.