Support ICU library provided by Windows 10 + Preset updates #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Oct 11, 2024
|
Something is failing here with function renaming across multiple ICU versions. |
carstene1ns
requested changes
Oct 12, 2024
When a custom ICU library is provided it takes preference over the system library. Fix EasyRPG#427
…n per Visual Studio Solution Before this generated Debug, RelWithDebInfo and Release and only one of them was working because not all libraries support this multi-dep cmake feature
… windows. Ninja does not support setting of the machine type. Instead the appropriate VS setup script must be executed beforehand. VS2022 targets are kept as they support this.
|
thanks for the fixes c1, added them |
carstene1ns
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the normalization code to the ICU C-API so looks more ugly now 😅 but C++ has no stable ABI so Microsoft decided to only provide the C part.
This does not remove 3rd party ICU support. When a custom ICU library is found it has preference.
Rest is just updating of presets based on Player preset updates.
For now I plan to keep using the vcpkg ICU library but when I do not want to maintain this anymore I can now simply drop it.