Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proper object element in batch action click listener #5952

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

teklakct
Copy link
Contributor

@teklakct teklakct commented Oct 9, 2023

Always read the object to which the click event is currently slated in the batch action listener.

This PR closes EasyCorp/EasyAdminBundle#5933

PS. Browserslist: caniuse-lite is outdated. I didn't update the db but it is highly recommended. If you want I can do it and add those changes to this PR.

@javiereguiluz javiereguiluz added this to the 4.x milestone Oct 21, 2023
@javiereguiluz javiereguiluz force-pushed the fix/button_batch_action branch from 64c8790 to c014c87 Compare October 21, 2023 16:54
@javiereguiluz
Copy link
Collaborator

Paweł, thanks a lot for fixing this bug. You are right about updating caniuse-lite and I'm going to do that in a following PR. Thanks!

@javiereguiluz javiereguiluz merged commit fc1aaab into EasyCorp:4.x Oct 21, 2023
19 checks passed
@teklakct teklakct deleted the fix/button_batch_action branch June 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use button as custom batch action
3 participants