fix(trix): fix trix editor config loading #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
changed the title
welcoMattic
force-pushed
the
fix-trix-editor-config
branch
from
47fc9a1 to
1f49189
Compare
|
Mathieu, thanks a lot for fixing this and for the detailed explanation. |
|
@javiereguiluz should I rebuild the JS, as it is versionned? Because now, master branche does not have the benefit of this fix as https://github.com/EasyCorp/EasyAdminBundle/blob/4.x/src/Resources/public/field-text-editor.47d6e6da.js has not changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5725
This PR change the listen event to boot TextEditorField. Before it listen on
DOMLoadedContent. Now it listen ontrix-before-initializeto be sure to handle the custom configuration and render properly aheading1element with a custom tagNameh2for example.If needed, I can add some tests to cover it.