Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RegisterTypes() abstract method #10

Open
duanenewman opened this issue Aug 19, 2020 · 0 comments
Open

Remove RegisterTypes() abstract method #10

duanenewman opened this issue Aug 19, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@duanenewman
Copy link
Member

duanenewman commented Aug 19, 2020

I think this was a result of refactoring the code into a library with support for multiple containers test frameworks. We shouldn't be calling a virtual method from a base constructor, since it can do strange things. I already had to put in check logic on the base Prism test classes to make sure it was called.. but really since it is called from the constructor it can just be done in each subclass's ctor as needed. This eliminates the need to make sure the base methods are called as well.

To Do:

  • remove call to RegisterType from IoC base class ctors
  • remove RegisterType from ContainerTestBase, convert all existing methods from overrides and simply call from containing class ctor.
@duanenewman duanenewman added the enhancement New feature or request label Aug 19, 2020
@duanenewman duanenewman self-assigned this Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant