Skip to content

Commit

Permalink
Skip validator-cpp tests for now (ampproject#38608)
Browse files Browse the repository at this point in the history
* test

* skip

* gh issue
  • Loading branch information
estherkim authored Jan 3, 2023
1 parent 141a8e1 commit e3ba25e
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions build-system/pr-check/validator-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const jobName = 'validator-tests.js';
function pushBuildWorkflow() {
timedExecOrDie('amp validator-webui');
timedExecOrDie('amp validator');
timedExecOrDie('amp validator-cpp');
// TODO(#38610): fix for bazel 6.0 or use older version
// timedExecOrDie('amp validator-cpp');
timedExecOrDie('amp validate-html-fixtures');
}

Expand Down Expand Up @@ -53,9 +54,10 @@ function prBuildWorkflow() {
timedExecOrDie('amp validator');
}

if (buildTargetsInclude(Targets.VALIDATOR)) {
timedExecOrDie('amp validator-cpp');
}
// TODO(#38610): fix for bazel 6.0 or use older version
// if (buildTargetsInclude(Targets.VALIDATOR)) {
// timedExecOrDie('amp validator-cpp');
// }

if (buildTargetsInclude(Targets.HTML_FIXTURES)) {
timedExecOrDie('amp validate-html-fixtures');
Expand Down

0 comments on commit e3ba25e

Please sign in to comment.