Cleanup layoutbox-invalidate-on-scroll experiment (ampproject#29665)

Fixes ampproject#25203
Eageashik · Aug 5, 2020 · bcac0dc · bcac0dc
1 parent 4a241bd
commit bcac0dc
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 14 deletions.
diff --git a/build-system/global-configs/canary-config.json b/build-system/global-configs/canary-config.json
@@ -28,7 +28,6 @@
   "hidden-mutation-observer": 1,
   "intersect-resources": 1,
   "ios-fixed-no-transfer": 1,
-  "layoutbox-invalidate-on-scroll": 1,
   "pump-early-frame": 1,
   "remove-task-timeout": 0,
   "swg-gpay-api": 1,

diff --git a/build-system/global-configs/prod-config.json b/build-system/global-configs/prod-config.json
@@ -29,7 +29,6 @@
   "hidden-mutation-observer": 1,
   "intersect-resources": 0.1,
   "ios-fixed-no-transfer": 0,
-  "layoutbox-invalidate-on-scroll": 1,
   "pump-early-frame": 1,
   "swg-gpay-api": 1,
   "swg-gpay-native": 1,

diff --git a/src/service/resources-impl.js b/src/service/resources-impl.js
@@ -312,10 +312,7 @@ export class ResourcesImpl {
 
     this.rebuildDomWhenReady_();
 
-    if (
-      !this.intersectionObserver_ &&
-      isExperimentOn(this.win, 'layoutbox-invalidate-on-scroll')
-    ) {
+    if (!this.intersectionObserver_) {
       /** @private @const */
       this.throttledScroll_ = throttle(this.win, (e) => this.scrolled_(e), 250);
 

diff --git a/tools/experiments/experiments-config.js b/tools/experiments/experiments-config.js
@@ -261,14 +261,6 @@ export const EXPERIMENTS = [
     spec: 'https://github.com/ampproject/amphtml/issues/25428',
     cleanupIssue: 'https://github.com/ampproject/amphtml/issues/26233',
   },
-  {
-    id: 'layoutbox-invalidate-on-scroll',
-    name:
-      'Invalidate the cached layoutboxes of elements nested in a scroller ' +
-      'after that scroller scrolls.',
-    spec: 'https://github.com/ampproject/amphtml/issues/24929',
-    cleanupIssue: 'https://github.com/ampproject/amphtml/issues/25203',
-  },
   {
     id: 'amp-stream-gallery',
     name: 'Enables component',