🔧 configure limits in a way that is consistent and makes sense #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2024 06:46
It looks like the limits applied to the JsYetiSimulator are on a per-phase basis, although limits applied elsewhere are not. This makes things very confusing. We will fix this by configuring everything to a per-phase limit of 16A Please see EVerest#92 (comment) to EVerest#92 (comment) Locations changed: - config - JsYetiSimulator - SmartCharging OCPP defaults Also fix the disable_iso_tls patch to not have a starting `/` Add a new patch file to enable limit logging but don't enable it by default. This may help future efforts to debug this. Signed-off-by: Shankari <[email protected]>
Consistent with EVerest#92 (comment) History starts at: EVerest#92 (comment) Also show dots in the chart Also convert the time range to/from local time so it makes sense Signed-off-by: Shankari <[email protected]>
Signed-off-by: Shankari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: UI fixes to show date/time in PST time, which makes the demo easier to show