Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire mambaforge - addendum to 3774 #3778

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 16, 2024

Description

A few more refrences to Mambaforge/mambaforge that I missed in #3774 - was in a hurry get that over the fence so we get our tests back, @bettina-gier pointed to me we have a few more changes to make 🍺

Note the RTD configuration is currently unable to get the Miniforge3 variant, see ESMValGroup/ESMValCore#2557


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@bettina-gier bettina-gier changed the title Retire mambaforge - addedndum to 3774 Retire mambaforge - addendum to 3774 Oct 16, 2024
Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you caught all the ones I found with grep now, and after changing the title to get rid of the typo I'm happy to approve.

@valeriupredoi
Copy link
Contributor Author

yay! Many thanks @bettina-gier 🍺

@valeriupredoi valeriupredoi merged commit 8303530 into main Oct 16, 2024
7 of 8 checks passed
@valeriupredoi valeriupredoi deleted the retire_Mambaforge_again branch October 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants