Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recreate perfmetrics portrait plot in python #3551

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Conversation

lukruh
Copy link
Contributor

@lukruh lukruh commented Mar 20, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor

what a noble venture, Lukas! Godspeed 🏁 🍺

@lukruh lukruh added this to the v2.11.0 milestone Apr 16, 2024
@lukruh lukruh added the new recipe Use this label if you are adding a new recipe label Nov 21, 2024
@lukruh lukruh marked this pull request as ready for review November 21, 2024 10:52
Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed, mostly in documentation.

Also requires ESMValGroup/ESMValCore#2564 to run with a current core bug on multi-model statistics.

doc/sphinx/source/recipes/recipe_perfmetrics.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_portrait.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_portrait.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_portrait.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_portrait.rst Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/portrait_plot.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/portrait_plot.py Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_portrait_CMIP.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_portrait_CMIP.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_portrait_CMIP.yml Outdated Show resolved Hide resolved
@lukruh lukruh added the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Nov 21, 2024
@lukruh
Copy link
Contributor Author

lukruh commented Nov 22, 2024

The recipe runs again with ESMValGroup/ESMValCore#2564. Should we wait for it before merging this?

@schlunma I adressed all your review comments. If you have time to re-review it, that would be awesome.

I added a cheaper version of the recipe to the recipes/testing folder. Is that the correct way to provide a test version? Should I also add it to RTW?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic new recipe Use this label if you are adding a new recipe requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recreate portrait plot from NCL perfmetrics in python
8 participants