-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recreate perfmetrics portrait plot in python #3551
base: main
Are you sure you want to change the base?
Conversation
what a noble venture, Lukas! Godspeed 🏁 🍺 |
… into perfmetric_python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes needed, mostly in documentation.
Also requires ESMValGroup/ESMValCore#2564 to run with a current core bug on multi-model statistics.
[skip ci] Co-authored-by: Bettina Gier <[email protected]>
[skip ci] Co-authored-by: Bettina Gier <[email protected]>
[skip ci] Co-authored-by: Bettina Gier <[email protected]>
[skip ci] Co-authored-by: Bettina Gier <[email protected]>
The recipe runs again with ESMValGroup/ESMValCore#2564. Should we wait for it before merging this? @schlunma I adressed all your review comments. If you have time to re-review it, that would be awesome. I added a cheaper version of the recipe to the |
[skip ci] Co-authored-by: Bettina Gier <[email protected]>
… into perfmetric_python
Description
portrait plot
from NCL perfmetrics in python #3550Before you get started
portrait plot
from NCL perfmetrics in python #3550Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: