Add cloud-init capability for Ubuntu #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser config while cloud-init still runs
Integrate the generation into a docker image. Add Ubuntu 22.04 Update and fix deployment
|
I guess this needs some rebasing / squashing? |
|
Yes we just merged into master in our fork and will have to cleanup in the next step |
stv0g
changed the title
Allow generation of images based on ubuntu 24.04
stv0g
previously approved these changes
May 28, 2024
|
@windrad6 Do you want to have these changes reviewed? |
stv0g
requested changes
Nov 29, 2024
| VAULT_KEY=$(tr -dc A-Za-z0-9 </dev/urandom | head -c 20; echo) | ||
| if [ -z "$VAULT_KEY" ]; then | ||
| echo "Generate ansible secret" | ||
| VAULT_KEY=$(tr -dc A-Za-z0-9 </dev/urandom | head -c 20; echo) |
There was a problem hiding this comment.
Suggested change
| VAULT_KEY=$(tr -dc A-Za-z0-9 </dev/urandom | head -c 20; echo) | |
| VAULT_KEY=$(tr -dc A-Za-z0-9 < /dev/urandom | head -c 20; echo) |
| @@ -86,6 +86,9 @@ echo "Using token: ${TOKEN}" | |||
| echo "Using flavor: ${FLAVOR}" | |||
| echo "Using repo: ${GIT_URL}" | |||
| echo "Using branch: ${GIT_BRANCH}" | |||
| if [! -z "$VAULT_KEY" ]; then | |||
There was a problem hiding this comment.
Suggested change
| if [! -z "$VAULT_KEY" ]; then | |
| if [ ! -z "$VAULT_KEY" ]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.