Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240925 xcompact3d capability #51

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JPRichings
Copy link
Contributor

This pull request adds a few tests to the xcompact3d reframe test:

  • Added xcompact3d_capability_ofi test designed to run at 4096 nodes.
    • Not currently tested at scale but has environment and scripts recommended by Paul B.
    • Target next Capability days to test.
  • Added xcompact3d_capability_ucx test designed to run at 2048 nodes.
    • Not currently tested at scale but has environment and scripts recommended by Paul B.
    • Target next Capability days to test.
  • Replaces xcompact3d_large test replacing the existing large test which runs on 1024 nodes
    • Not retested yet due to scale
  • Added xcompact3d test run on 64 node
    • Tested on Archer2 CPU
  • Added xcompact3d_small test run on 8 nodes
    • Tested on Archer2 CPU
  • Supporting input files also included in source directory
  • All tests build xcompact3d from a source on github

@JPRichings JPRichings self-assigned this Sep 26, 2024
@JPRichings JPRichings added the enhancement New feature or request label Sep 26, 2024
Copy link
Contributor

@aturner-epcc aturner-epcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JPRichings . Just a minor change to avoid causing issues with regular test runs.

valid_systems = ["archer2:compute-capability"]
valid_prog_environs = ["PrgEnv-gnu"]

tags = {"performance", "largescale", "applications"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the "largescale" tag to "hyperscale" here (or something else more appropriate? We use the "largescale" tag to run tests every week and we do not want to run the 4096 and 2048 sizes this often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have set up a new archer2 config for capability days so these shouldn't run normally. "valid_systems = ["archer2:compute-capability"]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes happy to add a new tag also

valid_prog_environs = ["PrgEnv-gnu"]
modules = ["craype-network-ucx"]

tags = {"performance", "largescale", "applications"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment above.

@aturner-epcc aturner-epcc self-requested a review September 26, 2024 15:41
Copy link
Contributor

@RuiApostolo RuiApostolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these many tests deserve a base class where they all inherit from - there's a lot of duplicated code, especially the sanity and performance functions.

@JPRichings
Copy link
Contributor Author

@RuiApostolo Yep your right I will rework as this is all common up to inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants