-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240925 xcompact3d capability #51
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JPRichings . Just a minor change to avoid causing issues with regular test runs.
valid_systems = ["archer2:compute-capability"] | ||
valid_prog_environs = ["PrgEnv-gnu"] | ||
|
||
tags = {"performance", "largescale", "applications"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the "largescale" tag to "hyperscale" here (or something else more appropriate? We use the "largescale" tag to run tests every week and we do not want to run the 4096 and 2048 sizes this often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have set up a new archer2 config for capability days so these shouldn't run normally. "valid_systems = ["archer2:compute-capability"]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but yes happy to add a new tag also
valid_prog_environs = ["PrgEnv-gnu"] | ||
modules = ["craype-network-ucx"] | ||
|
||
tags = {"performance", "largescale", "applications"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these many tests deserve a base class where they all inherit from - there's a lot of duplicated code, especially the sanity and performance functions.
@RuiApostolo Yep your right I will rework as this is all common up to inputs |
This pull request adds a few tests to the xcompact3d reframe test: