Test Slurm sets CPU frequency correctly #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lurm can be used to raise this to 2.25Ghz
|
I will update to appease the syntax/linting god (@RuiApostolo) |
It's the single-quotes in lines 45 and 48. |
RuiApostolo
requested changes
Sep 25, 2024
tests/env/cpu_freq_check.py
Outdated
|
|
||
| @rfm.simple_test | ||
| class CPUHighFreqTest(rfm.RunOnlyRegressionTest): | ||
| """Checks that CPU frequency is set to 2.25GHz by default""" |
There was a problem hiding this comment.
2.25GHz is not the default though, is it? I think the test and class descriptions should reflect that.
There was a problem hiding this comment.
Thanks I caught a couple of other similar doc string errors and have updated them
RuiApostolo
approved these changes
Sep 25, 2024
|
Thanks @JPRichings ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests for Archer2:
Slurm job with no --cpu-freq argument has SLURM_CPU_FREQ_REQ=2000000
Slurm job with --cpu-freq=2250000 argument has SLURM_CPU_FREQ_REQ=2250000