Merge pull request #608 from ELEVATE-Project/issue#1247

fix for undefined in get signed url

src/controllers/v1/cloud-services.js

@@ -18,7 +18,7 @@ module.exports = class CloudServices {
 		try {
 			const signedUrlResponse = await filesService.getSignedUrl(
 				req.query.fileName,
-				req.decodedToken._id,
+				req.decodedToken.id,
 				req.query.dynamicPath ? req.query.dynamicPath : ''
 			)
 			return signedUrlResponse

src/services/files.js

@@ -5,13 +5,13 @@ const utils = require('@generics/utils')
 const responses = require('@helpers/responses')
 
 module.exports = class FilesHelper {
-	static async getSignedUrl(fileName, _id, dynamicPath) {
+	static async getSignedUrl(fileName, id, dynamicPath) {
 		try {
 			let destFilePath
 			if (dynamicPath != '') {
 				destFilePath = dynamicPath + '/' + fileName
 			} else {
-				destFilePath = `session/${_id}-${new Date().getTime()}-${fileName}`
+				destFilePath = `session/${id}-${new Date().getTime()}-${fileName}`
 			}
 			let response
 			if (process.env.CLOUD_STORAGE === 'GCP') {

src/services/sessions.js

@@ -212,6 +212,14 @@ module.exports = class SessionsHelper {
 
 			// Create session
 			const data = await sessionQueries.create(bodyData)
+			if (!data?.id) {
+				return responses.failureResponse({
+					message: 'SESSION_CREATION_FAILED',
+					statusCode: httpStatusCode.bad_request,
+					responseCode: 'CLIENT_ERROR',
+					result: res.errors,
+				})
+			}
 			// If menteeIds are provided in the req body enroll them
 			if (menteeIdsToEnroll.length > 0) {
 				await this.addMentees(data.id, menteeIdsToEnroll, bodyData.time_zone)