scp-story#1359 - Enhancing entity management #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VISHNUDAS-tunerlabs
requested changes
Dec 13, 2024
VISHNUDAS-tunerlabs
requested changes
Dec 16, 2024
| @@ -185,9 +211,11 @@ module.exports = class UserProjectsHelper { | |||
| /** | |||
| * Fetches targeted roles based on the provided entity IDs. | |||
| * @param {Array<string>} entityId - An array of entity IDs to filter roles. | |||
| * @param {params} pageSize - page pageSize. | |||
| * @param {params} pageNo - page no. | |||
There was a problem hiding this comment.
@adithyadinesh0412 Please ad explanation for paginate param as well
| @@ -927,10 +958,12 @@ module.exports = class UserProjectsHelper { | |||
| * @method | |||
| * @name entityListBasedOnEntityType | |||
| * @param {string} type - Type of entity to fetch documents for. | |||
| * @param {string} pageNo - pageNo for pagination | |||
| * @param {string} pageSize - pageSize for pagination | |||
There was a problem hiding this comment.
@adithyadinesh0412 update function signature
| @@ -87,13 +87,23 @@ module.exports = class userRoleExtensionHelper { | |||
| * Find user role extensions based on the provided query and projection. | |||
| * @param {Object} bodyQuery - The query to filter user role extensions. | |||
| * @param {Array<String>} projection - The fields to include in the returned documents. | |||
| * @param {string} limit - limit for pagination | |||
| * @param {string} offset - offset for pagination | |||
There was a problem hiding this comment.
@adithyadinesh0412 check and verify all the function signatures once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done -
Added pagination to APIs :
Updated subEntitiesList API to share the parent entities as well in the response.