Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to header file liblte_rrc.h that was removed upstream #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pellaeon
Copy link

@pellaeon pellaeon commented Mar 2, 2019

This will fix build error.

This should not bring any effect during execution, but I'm not fully sure. As far as I checked, all the references to the old lib were removed.

@void-elf
Copy link
Collaborator

void-elf commented Mar 3, 2019

Posted this message in a chat, but just going to put it here for other people to see: so we had this same change in an earlier PR, but it actually breaks compilation on some linux boxes, despite the fact that srslte/asn1/liblte_rrc.h doesn't exist and was removed here: 684b7d2#diff-07c3d376a4e489bbc936d0b295c85928. We're not sure what's going on, but yeah obvs keep it deleted locally if it's not broken/working normally for you, but we can't merge your PR until we figure out why it only compiles on some of our machines and not others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants