[610] Improved process_iter #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significant speed-up. Around 20x in psutils 6.0!
Rixxan
added
enhancement
code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
psutils6.0 added a new change to process_iter which improves performance substantially to the point where it is now actually worth using. The functionno longer checks whether each yielded process PID has been reusedper PSUtils docs, which generates an ~20x speed-up to use, which actually makes it worth using versus iterating through functions. This shaves almost half a second off of my testing, meaning less app freezes and a better working check.Type of Change
Enhancement
How Tested
Tested and timed on my system running from source
Notes
giampaolo/psutil#2396