[1805] Prototype More Functions #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
enhancement
code cleanup
This was
linked to
issues
Jun 18, 2024
ElSaico
added a commit
to ElSaico/EDMarketConnector
that referenced
this pull request
Jun 24, 2024
Also updated theme.py to pywin32 ahead of EDCD#2263, in order to minimize the merging mess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hands over duties for a number of direct calls to the Win32 API to the pywin32 library. These calls help properly prototype a number of used functions and reduce reliance on the direct calling of the Win32 API.
This has the added benefit of helping to properly set up the code to be more stable and reliable when using built 64-bit versions of EDMC. Where pywin32 isn't available, proper prototyping of direct win32 api calls h ave been performed to enhance stability.
Additionally, makes changes to enable the usage of game_running() on Linux.
Type of Change
Enhancement
How Tested
Tested using multiple local builds of EDMC on 32 and 64 bit Windows and ensuring the program executes properly.
Notes
Related to #1805 (though a second look is due when pywin32 307 comes out)
Replaces #1808
Closes #610