Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update Translations, Fix Menu Creation, Fix Alt URL #2238

Merged
merged 1 commit into from
May 24, 2024

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented May 21, 2024

Description

This PR fixes a few identified bugs with newly added features to EDMC, particularly the right-click pop-up menus on the main window for opening items in alternate providers.

  1. Adds three new translatable strings
  2. Fixes a bug that could result in alternate URL providers not opening the proper resource
  3. Fixes a bug that could result in changing languages not properly translating the right-click pop-up menus until a full restart

Type of Change

  • Bug Fix

How Tested

Tested with multiple languages and URL provider conditions

@Rixxan Rixxan added bug Translations python Pull requests that update Python code ui User Interface Ready for Review PRs ready for review and merge labels May 21, 2024
@Rixxan Rixxan added this to the 5.11 milestone May 21, 2024
@Rixxan Rixxan requested a review from C1701D May 21, 2024 21:04
@Rixxan Rixxan self-assigned this May 21, 2024
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rixxan Rixxan merged commit ecc46dc into EDCD:develop May 24, 2024
3 checks passed
@Rixxan Rixxan deleted the fix/translate-copy-menu branch May 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug python Pull requests that update Python code Ready for Review PRs ready for review and merge Translations ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants