[830] Open Log Folder Natively #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
enhancement
OS Issue
New User Experience
Linux
|
I tested this and it works on Arch Linux in Cinnamon DE 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when choosing "Open Plugin Location" on Linux, the system calls the web-browser and instead opens the directory in the web-browser instead of the file explorer. This is sub-optimal. Instead of calling the web-browser, this PR instructs the OS to open the file or folder indicated natively.
This is done by leveraging the
help_open_log_folder()function (renamed toopen_folder()), and generalizing the file. The existinghelp_open_log_folder()is deprecated and slated for removal in 6.0.Type of Change
How Tested
Notes
Resolves #830