Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2198] Cleanup Dependency Clutter #2208

Merged
merged 3 commits into from
May 11, 2024

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Apr 20, 2024

Description

Certifi and charset-normalizer are dependencies of Requests. As such, we should let Requests handle which version those programs want without pinning them ourselves. This reduces the overhead we have to maintain as well as helps to prevent issues with dependency updates.

Additionally, removes argh and pyyaml for similar reasons.

Type of change

  • Dependency Update

How Has This Been Tested?

  • Building with clean environments and on GH actions to ensure that the required dependencies are included.

Resolves #2198

@Rixxan Rixxan added code cleanup Cleaning up code dependencies Pull requests that update a dependency file Ready for Review PRs ready for review and merge labels Apr 20, 2024
@Rixxan Rixxan added this to the 5.11.0 milestone Apr 20, 2024
@Rixxan Rixxan requested a review from C1701D April 20, 2024 21:48
@Rixxan Rixxan self-assigned this Apr 20, 2024
@Rixxan Rixxan linked an issue Apr 26, 2024 that may be closed by this pull request
@C1701D C1701D merged commit 456db7b into EDCD:develop May 11, 2024
3 checks passed
@C1701D C1701D deleted the enhancement/2198/test-dependencies branch May 11, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code dependencies Pull requests that update a dependency file Ready for Review PRs ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Charset Normalizer Anomalies
2 participants