Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2202] Add a number of missing modules #2204

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Apr 15, 2024

TCE has identified an error where the new SCO modules weren't being detected by EDMC. This is a two-part issue:

  1. The FDEVID files which we use for a lot of things haven't been updated (New Frame Shift Drive modules with Super Cruise Overcharge FDevIDs#88)
  2. We didn't have the code to process these oddly named modules. These two together caused a number of errors and caused EDMC to be considered "crashed" to some tools like TCE.

While investigating this, it was discovered that if one of these missing modules (universal limpet controllers and some of the thargoid war stuff) was encountered, it would stop the module review and leave out-of-date or incomplete module exports from stations.

This PR adds the logic to process these missing modules.

Resolves #2202

This will need to be basically speedran into live.
@Rixxan Rixxan added bug python Pull requests that update Python code Odyssey Issues against Odyssey Ready for Review PRs ready for review and merge labels Apr 15, 2024
@Rixxan Rixxan added this to the 5.11.0 milestone Apr 15, 2024
@Rixxan Rixxan requested a review from C1701D April 15, 2024 00:24
@Rixxan Rixxan self-assigned this Apr 15, 2024
@Rixxan Rixxan linked an issue Apr 15, 2024 that may be closed by this pull request
@Rixxan Rixxan merged commit fdd6c6c into EDCD:develop Apr 15, 2024
1 check passed
@Rixxan Rixxan deleted the enhancement/2202/add-missing-modules branch April 15, 2024 20:33
Rixxan added a commit that referenced this pull request Apr 15, 2024
…modules

[2202] Add a number of missing modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Odyssey Issues against Odyssey python Pull requests that update Python code Ready for Review PRs ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another error with the -o parameter of EDMC.exe getting exitcode 1
1 participant