Broken Plugins Popup #2110
Merged
Broken Plugins Popup #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a Popup at startup about Plugins that failed to load. - Adds entry about broken Plugins in the Settings - Plugins tab. - Adds corresponding translation entries.
Also includes a minor fix for try/except if coriolis-data is missing
Forgot to update the comment to be about broken plugins instead of no 3.x support ones.
Rixxan
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a popup at startup about plugins that failed to load, presumably due to a wrong folder structure. This popup will come up at every EDMC start, unlike the "Plugin without Python 3.x support" one that only pops up every 24h. This PR also adds a list of those Plugins under their own entry in the Settings - Plugins tab.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
find_localised_strings.pydoesn't complain.