Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1843] Update URL Parameter Encoding #2108

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Dec 13, 2023

Description

In rare edge cases, how the API authentication key is called can be sent to the web browser incorrectly, meaning that the request fails on the API scope query. This endeavors to remove the ambiguous space, given the evidence and logs provided in #1843.

Type of change

  • Minor Bug Fix

How Has This Been Tested?

  • Tests of installation, operation, and building on the developer's machine
  • All PyTest tests pass

Closes #1843

Replaces vague space with properly encoded %20. This SHOULD solve the issue, but I can't replicate the original issue.
@Rixxan Rixxan added the bug label Dec 13, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Dec 13, 2023
@Rixxan Rixxan requested a review from C1701D December 13, 2023 02:32
@Rixxan Rixxan self-assigned this Dec 13, 2023
@Rixxan Rixxan linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with latest releases of Firefox, Edge, Chrome, Brave and Opera, they all work without any issues.

@C1701D C1701D merged commit cb7fbfc into EDCD:develop Dec 13, 2023
1 check passed
@C1701D C1701D deleted the fix/1843/url_params branch December 13, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't authorise
2 participants