Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2051] Update Supporting Files #2097

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Nov 17, 2023

Description

Updates 7 of the supporting core EDMC files with a Semver-compliant pass. Updates type hints to modern-style standards (PEP 585), removes a few Python 2-era definitions, and clarifies some unions and attribute checkers.

Derived from #2068

Type of change

  • Rewrite of Existing Code

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tests of installation, operation, and building on developer machine
  • All PyTest tests pass

Not touching any of the big ones, but some clarification updates to many of the supporting files.
@Rixxan Rixxan added the code cleanup Cleaning up code label Nov 17, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Nov 17, 2023
@Rixxan Rixxan requested a review from C1701D November 17, 2023 16:40
@Rixxan Rixxan self-assigned this Nov 17, 2023
Whoops. Only fetch a new session if it's None.

Co-Authored-By: Phoebe <[email protected]>
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C1701D C1701D merged commit a3021f8 into EDCD:develop Nov 17, 2023
1 check passed
@C1701D C1701D deleted the enhancement/2051/misc-updates branch November 17, 2023 16:56
@Rixxan Rixxan linked an issue Dec 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Existing Code - Non Breaking Updates
2 participants