Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and standardize Settings UI #2096

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Fix and standardize Settings UI #2096

merged 5 commits into from
Nov 17, 2023

Conversation

C1701D
Copy link
Member

@C1701D C1701D commented Nov 17, 2023 •
edited by Rixxan
Loading

Description

The UI in the settings panels is currently not standardized. The Paddings used vary wildly with signs of a pattern that's not used everywhere though. This creates a standard for the settings UI and applies it to the panels. This standard can also be used as a reference for future updates and be given to Plugin developers to achieve a uniform look.

Closes #2088, #2089, #2095

Type of change

  • Fixes indentation on non-English languages with varying character spacing
  • Fixes a number of issues with labels overwriting the content they are displaying on
  • Implementation of settings UI standard

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Multiple install runs, clean installs, and others made to confirm functionality, including under a variety of existing pre-install situations.
  • All PyTest tests pass

Phoebe added 5 commits November 16, 2023 22:21
[2088] fix UI bugs, introduce standard
07ae14b 
- Fixes EDCD#2088 and EDCD#2089.
- Adds usage of ``row=`` for ``.grid()`` for all config entries in included plugins.
- Changes all config pages to start at row 0.
- Starts introducing a standard for config panel layouts.
[Minor] flake8
e878453
[2095] Standardize vertical Padding
8063cf0 
- Standardizes vertical Padding.
- Fixes issues with the disabled and outdated Plugin list.
- Part of EDCD#2095
[Minor] flake8
fc9775b
[2095] Standardize horizontal Padding
a3c1763 
- Standardizes horizontal Padding.
- Fixes further padding issues.
- Part of EDCD#2095
@C1701D C1701D added enhancement Plugins Anything related to plugins labels Nov 17, 2023
@C1701D C1701D added this to the 5.10.0 milestone Nov 17, 2023
@C1701D C1701D requested a review from Rixxan November 17, 2023 02:24
@C1701D C1701D self-assigned this Nov 17, 2023
This was linked to issues Nov 17, 2023
Privacy Panel Indentation #2088
Closed
Plugin address box displayed incorrectly #2089
Closed
Standardize Settings UI #2095
Closed
Rixxan
Rixxan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Rixxan Rixxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Fantastic addition of standards and readability.

Only request: Sometime you should write a doc/guide on how to make UI layouts to the new standard.

@Rixxan Rixxan added code cleanup Cleaning up code ui User Interface labels Nov 17, 2023
@Rixxan Rixxan merged commit 6c06600 into EDCD:develop Nov 17, 2023
1 check passed
@Rixxan Rixxan deleted the fix/2088/fix-and-standardize-UI branch November 17, 2023 02:42
This was referenced Nov 17, 2023
Closed
Closed
@C1701D C1701D restored the fix/2088/fix-and-standardize-UI branch November 17, 2023 15:24
@C1701D C1701D deleted the fix/2088/fix-and-standardize-UI branch November 17, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rixxan Rixxan Rixxan approved these changes

Assignees

@C1701D C1701D

Labels
code cleanup Cleaning up code enhancement Plugins Anything related to plugins ui User Interface
Projects
None yet
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.

Standardize Settings UI Plugin address box displayed incorrectly Privacy Panel Indentation
2 participants
@C1701D @Rixxan