[2051] Don't Overwrite Every Session

Whoops. Only fetch a new session if it's None.

Co-Authored-By: Phoebe <[email protected]>

timeout_session.py

@@ -7,8 +7,7 @@
 """
 from __future__ import annotations
 
-import requests
-from requests import Session
+from requests import Session, Response
 from requests.adapters import HTTPAdapter
 from config import user_agent
 
@@ -25,27 +24,27 @@ def __init__(self, timeout: int, *args, **kwargs):
 
         super().__init__(*args, **kwargs)
 
-    def send(self, *args, **kwargs) -> requests.Response:
+    def send(self, *args, **kwargs) -> Response:
         """Send, but with a timeout always set."""
         if kwargs["timeout"] is None:
             kwargs["timeout"] = self.default_timeout
 
         return super().send(*args, **kwargs)
 
 
-def new_session(
-    timeout: int = REQUEST_TIMEOUT, session: requests.Session | None = None
-) -> requests.Session:
+def new_session(timeout: int = REQUEST_TIMEOUT, session: Session | None = None) -> Session:
     """
     Create a new requests.Session and override the default HTTPAdapter with a TimeoutAdapter.
 
     :param timeout: the timeout to set the TimeoutAdapter to, defaults to REQUEST_TIMEOUT
     :param session: the Session object to attach the Adapter to, defaults to a new session
     :return: The created Session
     """
-    with Session() as session:
-        session.headers['User-Agent'] = user_agent
-        adapter = TimeoutAdapter(timeout)
-        session.mount("http://", adapter)
-        session.mount("https://", adapter)
-        return session
+    session = session or Session()
+    session.headers.setdefault("User-Agent", user_agent)
+
+    adapter = TimeoutAdapter(timeout)
+    for prefix in ("http://", "https://"):
+        session.mount(prefix, adapter)
+
+    return session