-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove distutils #451
Remove distutils #451
Conversation
adf0f51
to
949e245
Compare
README.md
Outdated
@@ -30,189 +30,7 @@ Our workflow is described in [CONTRIBUTING.rst](CONTRIBUTING.rst). | |||
|
|||
## Developer Environment | |||
|
|||
Please prepare you local development environment as follows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine here, but would be cleaner if this change was done in a separate PR since it isn't related to the main topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, sorry that was a it sloppy and makes this harder to Backport/patch where needed indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to #453
This looks good and I can approve, though I have one comment posted. Would there be a way to put all of the "python -m pip install" commands in a script so that they don't need to be written out in each of the 10 files as is now? |
Yes, technically this is all in pyproject.yaml, let me see how to install that in a two liner or so. Pip has to definitely be upgraded first and solely, because some people start with ancient pip installs that would not understand later pip steps we do. Update: since we do not build with |
Distutils is gone in Python 3.12+.
949e245
to
c9626f3
Compare
Distutils is gone in Python 3.12+.
Refs.: