Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest: Temporary Working Directory #424

Merged
merged 4 commits into from
Aug 30, 2023
Merged

pytest: Temporary Working Directory #424

merged 4 commits into from
Aug 30, 2023

Commits on Aug 28, 2023

  1. Fix: pytest Wait 1 Sec 

    Simetimes our tests are so quick that they
finish below 1second. That does not work with
`UniqueStrings` in AMReX' `UtilCreateCleanDirectory`,
which can only do one name per second:
https://github.com/AMReX-Codes/amrex/blob/23.08/Src/Base/AMReX_Utility.cpp#L186-L199

If the target exist, the behavior of `std::rename` is
implementation dependent. We see crashes of this
on macOS.
https://en.cppreference.com/w/cpp/io/c/rename
    @ax3l
    ax3l committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    594ee4e View commit details
    Browse the repository at this point in the history

  2. Use Temporary Working Directory 

    Avoid clean-up needs by using a cwd that is unique per test.
    @ax3l
    ax3l committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    62eeabe View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. All the yielded results in the cwd context

    @ax3l
    ax3l authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7457cf7 View commit details
    Browse the repository at this point in the history

  2. Set CWD of runner

    @ax3l
    ax3l committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    680e2cf View commit details
    Browse the repository at this point in the history