Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
…k which is being serviced by a flask based back end framework. There is no functionality. Currently, I send simple objects through flask to render using react. Updated the readme file with instructions for other developers to set up the application locally.
Initally setup the application
…own. Also added about us and help tabs which will be filled out at a later date. Waiting for backend changes to connect the newly added components.
Added initial component logic
with team * Retrieved basic queries from spoontacular API
…eval. Recipes return name and images which are linked to spoontacular's website.
Created endpoint to query for recipes. Images are included in JSON response.
Implemented api query for ingredients based search
Input ingredients
… (with searched ingredients highlighted when applicable), and step by step instructions.
…r name search algorithm and do error checking
Implemented recipe details dialog which renders the image, ingredients…
Allow users to search for any specific recipe
…w be seen in card form. Additionally, when user clicks on a card, the respective recipe details popup shows up.
Connected recipe cards with each search page so search results can no…
Changes to allow deployment on Heroku and Firebase
- Added a new search bar for ingredients for better UX - Added a new logo
Ingredient Searchbar and General UI Enchancements
added backend unit tests
…t with new ingredient search page changes. Added minor UI improvements and alignment fixes to all components. Added loader while searching. Fixed bug which prevented dialog to open when recipe did not have steps in its info.
Added UI tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @PuaChris @honeyjoo @devesh-nischal @matthewviegas