mac build issue resolution #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac build failure, checked with Monterey - arm, reasons were
libodb and libodb_sqlite packages having a file named "version", which is not a c/c++ file, gets included in build instead of the file "version" in c++ sdk include files due to include path specs.
The version files are renamed during installation as version_odb and version_sqlite, that correct version file is included for build.
packages brotli and ssl were old and did not support newer Mac platforms.
These packages are updated to versions which support Mac arm 64bit as well.
The min build platform for Mac is set as 12.0, to avoid warnings during build.
Brotli package is built twice to get dynamic and static libraries, required for curl and vcf validator. (earlier version had both built as binaries with different name and new version have both static and dynamic output with same name). vcf-validator's CMakeFile.txt is also updated to work with new brotli output name.
Fixes #226