Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3660: Script to detect and update variants in variant warehouse that need normalisation #180

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

apriltuesday
Copy link
Contributor

@apriltuesday apriltuesday commented Nov 1, 2024

Remaining tasks:

  • Get FASTA file
  • Resolve secondary alternates issue (see here)
  • Contig naming translation
  • Test comparing our normalisation with bcftools norm output
  • Tests for remediation itself

Guide for reviewers:

  • RemediationApplication - main remediation script, borrows heavily from EVA-3667 for merge strategy but differs in the need to split documents
  • VariantStatsProcessor - copied verbatim from EVA-3667, don't need to review this
  • NormalisationProcessor - implementation of normalisation algorithm
  • ContigRenamingProcessor - small class to rename contigs using assembly report

@apriltuesday apriltuesday self-assigned this Nov 15, 2024
@apriltuesday apriltuesday marked this pull request as ready for review November 15, 2024 10:12
@apriltuesday
Copy link
Contributor Author

Still working on tests, otherwise this can be looked at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant