Skip to content

Commit

Permalink
add TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
apriltuesday committed Apr 30, 2021
1 parent f92d583 commit 37ee8b3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions eva_submission/eload_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def get_mongo_creds():
properties = get_properties_from_xml_file(cfg['maven']['environment'], cfg['maven']['settings_file'])
# Use the primary mongo host from configuration:
# https://github.com/EBIvariation/configuration/blob/master/eva-maven-settings.xml#L111
# TODO: revisit once accessioning/variant pipelines can support multiple hosts
mongo_host = split_hosts(properties['eva.mongo.host'])[1][0]
mongo_user = properties['eva.mongo.user']
mongo_pass = properties['eva.mongo.passwd']
Expand Down
1 change: 1 addition & 0 deletions nextflow/accession.nf
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ process accession_vcf {
(java -Xmx7g -jar $params.jar.accession_pipeline --spring.config.name=\$filename) || \
# If accessioning fails due to missing variants, but the only missing variants are structural variants,
# then we should treat this as a success from the perspective of the automation.
# TODO revert once accessioning pipeline properly registers structural variants
[[ \$(grep -o 'Skipped processing structural variant' ${params.logs_dir}/${log_filename}.log | wc -l) \
== \$(grep -oP '\\d+(?= unaccessioned variants need to be checked)' ${params.logs_dir}/${log_filename}.log) ]]
echo "done" > ${accessioned_filename}.tmp
Expand Down

0 comments on commit 37ee8b3

Please sign in to comment.